Skip to content

Don't close next sequence when moving backwards #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shvaikalesh merged 1 commit into from
May 30, 2020
Merged

Don't close next sequence when moving backwards #150

shvaikalesh merged 1 commit into from
May 30, 2020

Conversation

@shvaikalesh
Copy link
Contributor

@shvaikalesh shvaikalesh commented May 29, 2020

Resolves shower/shower#358.

@shvaikalesh shvaikalesh requested a review from pepelsbey May 29, 2020 22:49
pepelsbey
pepelsbey approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@pepelsbey pepelsbey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now it works exactly how it supposed to, from the very beginning.

@shvaikalesh
Copy link
Contributor Author

shvaikalesh commented May 30, 2020

It is nice that apart from making next sequences more intuitive, this change also makes the code more approachable.

@shvaikalesh shvaikalesh merged commit 2ab600e into master May 30, 2020
@shvaikalesh shvaikalesh deleted the next-dont-backwards-complete branch May 30, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wait until the slide change before closing next sequence

3 participants

@shvaikalesh @pepelsbey