Expand Shopify cable ingestion across more brands#47
Merged
anand-testcompare merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughExtends Shopify cable source with support for five additional brands (Native Union, Satechi, Mous, Baseus, UGREEN) via brand-specific templates. Updates product slug derivation to dynamically use brand information. Adds resilient product data fetching with fallback mechanisms and improved URL/text normalization logic. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ProductURL
participant NextData
participant SearchSuggest
participant ProductJSON
participant Internal
Client->>ProductURL: extractFromProductUrl(url)
ProductURL->>NextData: fetchNextData()
alt Next Data Available
NextData-->>ProductURL: Product Data
ProductURL->>Internal: Convert to ShopifyProduct
else Next Data Failed/Missing
NextData-->>ProductURL: Recoverable Error
ProductURL->>SearchSuggest: fetchSearchSuggestCandidates()
SearchSuggest-->>ProductURL: Candidate URLs
ProductURL->>ProductJSON: fetchProductJson(candidateUrl)
ProductJSON-->>ProductURL: Product JSON
ProductURL->>Internal: mapProductJsonToShopifyProduct()
end
Internal-->>Client: Extracted ShopifyProduct
Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search/suggest.jsondiscovery and/products/<handle>.jspayloadsn/a,unknown) back to canonical brand and normalize protocol-relative image URLsankerValidation
bun test packages/shopify-cable-source/src/source.integration.test.tsbun test packages/backend/convex/shopify.ingest.integration.test.tsbun test apps/web/src/lib/mappers.test.tsbun run check-typesbun x ultracite check apps/web/src/lib/mappers.ts apps/web/src/lib/mappers.test.ts packages/shopify-cable-source/src/source.ts packages/shopify-cable-source/src/source.integration.test.ts packages/shopify-cable-source/src/templates/index.ts packages/shopify-cable-source/src/templates/native-union.ts packages/shopify-cable-source/src/templates/satechi.ts packages/shopify-cable-source/src/templates/mous.ts packages/shopify-cable-source/src/templates/baseus.ts packages/shopify-cable-source/src/templates/ugreen.tsSummary by CodeRabbit
New Features
Bug Fixes
Tests