Follow-up: cap suggest lookups to prevent CI timeout#56
Merged
anand-testcompare merged 1 commit intomainfrom Feb 19, 2026
Merged
Follow-up: cap suggest lookups to prevent CI timeout#56anand-testcompare merged 1 commit intomainfrom
anand-testcompare merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughThe source file enhances the Shopify product discovery flow by introducing capability-detection helpers, caching mechanisms, and fallback search logic. Added regex patterns for case-insensitive hint matching, control flags for endpoint availability and catalog loading state, and helper functions to derive descriptions from cached results or fallback searches. Changes
Sequence DiagramsequenceDiagram
participant Client
participant SuggestEndpoint as Suggest Endpoint
participant Cache as Description Cache
participant FallbackSearch as Fallback Search
participant Extractor as Product Extractor
Client->>SuggestEndpoint: Fetch product suggestions
alt Suggest Endpoint Available
SuggestEndpoint-->>Client: Return suggestions
Client->>Cache: Check cached descriptions
alt Description in Cache
Cache-->>Client: Return cached description
else Description Not Cached
Client->>SuggestEndpoint: Request supplemental description
SuggestEndpoint-->>Client: Return supplemental data
Client->>Cache: Store description
end
else Suggest Endpoint Unavailable (404)
SuggestEndpoint-->>Client: 404 Error
Client->>FallbackSearch: Execute fallback search
FallbackSearch-->>Client: Return fallback results
Client->>Cache: Derive description from fallback
end
Client->>Extractor: Pass product with description
Extractor-->>Client: Complete product extraction
Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
404responseValidation
bun test packages/backend/convex/shopify.ingest.integration.test.tsbun x ultracite check packages/shopify-cable-source/src/source.tsbun run check-typesSummary by CodeRabbit