feat(web): switch branding icon to transparent teal/white shield#62
Merged
anand-testcompare merged 3 commits intomainfrom Feb 20, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoves the Convex Delete Deployments skill (docs, OpenAI interface, and CLI), adds Changes
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
56-57: Consider reducing extra blank lines.Two consecutive blank lines before the
.agentsentry is unconventional for.gitignorefiles. Typically, one blank line (or none) is used to separate logical sections.Minor formatting suggestion
- - + .agents🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore around lines 56 - 57, Remove the extra blank line(s) before the `.agents` entry in the .gitignore so there is at most one blank line (or none) separating sections; edit the .gitignore to collapse the two consecutive blank lines into a single blank line (or delete both) so the `.agents` entry sits directly after a single separator for consistent formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Around line 56-57: Remove the extra blank line(s) before the `.agents` entry
in the .gitignore so there is at most one blank line (or none) separating
sections; edit the .gitignore to collapse the two consecutive blank lines into a
single blank line (or delete both) so the `.agents` entry sits directly after a
single separator for consistent formatting.
anand-testcompare
changed the title
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/src/app.html (1)
5-14: Consider using appropriately sized favicon assets.Using a 1024x1024 PNG for the favicon is significantly larger than typical favicon sizes (16x16, 32x32, 48x48). This may unnecessarily increase initial page load time since browsers will download the full-size image and scale it down.
For apple-touch-icon, the recommended size is 180x180 pixels.
Consider providing properly sized assets or generating multiple sizes:
💡 Suggested approach
<link rel="icon" - href="%sveltekit.assets%/cable-intel-shield-usbc-transparent-teal-white.png" + href="%sveltekit.assets%/favicon-32x32.png" type="image/png" - sizes="1024x1024" + sizes="32x32" > <link rel="apple-touch-icon" - href="%sveltekit.assets%/cable-intel-shield-usbc-transparent-teal-white.png" + href="%sveltekit.assets%/apple-touch-icon-180x180.png" >🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app.html` around lines 5 - 14, Replace the oversized 1024x1024 asset usage in the link elements by providing appropriately sized favicon files and links: keep the link rel="icon" but point to/emit multiple assets (e.g., 16x16, 32x32, 48x48) and set the sizes attribute accordingly, and replace the apple-touch-icon href to a 180x180 asset; ensure the original filename (cable-intel-shield-usbc-transparent-teal-white.png) is re-exported in those resized variants and include a reasonable fallback to the existing 1024 PNG only if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/web/src/app.html`:
- Around line 5-14: Replace the oversized 1024x1024 asset usage in the link
elements by providing appropriately sized favicon files and links: keep the link
rel="icon" but point to/emit multiple assets (e.g., 16x16, 32x32, 48x48) and set
the sizes attribute accordingly, and replace the apple-touch-icon href to a
180x180 asset; ensure the original filename
(cable-intel-shield-usbc-transparent-teal-white.png) is re-exported in those
resized variants and include a reasonable fallback to the existing 1024 PNG only
if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/static/cable-intel-shield-usbc-rounded.png)apps/web/staticValidation
bun x ultracite check apps/web/src/app.html apps/web/src/components/header.svelte apps/web/src/app.cssbun run --cwd apps/web checkbun run --cwd apps/web buildhttp://127.0.0.1:4173//tmp/cable-intel-after-icon-update.pngNotes
.gitignoreand.ignoreuntouchedSummary by CodeRabbit