feat: complete #120 cross-surface continuity + real device oauth e2e#182
Merged
anand-testcompare merged 9 commits intomainfrom Mar 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8aab58b to
5a7fba6
Compare
Contributor
Browserbase Replays
Workflow run: 22559637289 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Summary
This PR completes issue #120 end-to-end across phases 1-5:
No API key/rate-limit/billing/M2M scope was added.
Acceptance Criteria Mapping (#120)
1) Thread-backed architecture
/api/diagrams/thread-runflows in continuity scenarios.sessionId+threadIdwith full history continuity.2) Tool loop + correctness
promptMessageIdverified (duplicate prompt id does not fork session).expectedVersionconflict + recovery.3) Streaming + high-reactivity UX
Running->Persisted).4) Cross-surface continuity
/api/auth/device/start|token.5) UX polish
/diagramsredirect, generator sign-in gating, device start URL contract).Implementation Details
Auth/device flow migration
apps/web/src/lib/workos-device-auth.tsapps/web/src/lib/workos-device-auth.test.tsapps/web/src/app/api/auth/device/start/route.tsapps/web/src/app/api/auth/device/token/route.tspackages/backend/convex/deviceAuth.ts(deleted)packages/backend/convex/deviceAuth.test.ts(deleted)apps/web/src/app/opencode/device/page.tsxE2E/CI hardening
packages/backend/scripts/mint-device-token.mjs.github/workflows/e2e-api.ymltests/e2e/src/scenarios/unauthenticated/opencode-web-continuity.ts.github/workflows/e2e-web.ymltests/e2e/src/scenarios/unauthenticated/auth-gates.ts.vercelignoreto reduce preview deploy payload noise.Verification Evidence
Required commands (local)
All required commands completed successfully:
bun x ultracite check✅bun run check-types✅bun run build✅cd packages/backend && bunx convex codegen && bun run test✅ (20files /70tests passed)Targeted tests
bun test apps/web/src/lib/workos-device-auth.test.ts✅ (4tests passed)Real E2E scenarios (non-mock core continuity)
opencode-web-continuity(Browserbase) ✅opencode-web-continuity(Local Stagehand against preview) ✅auth-gates(Browserbase) ✅tests/api/auth-device.ymltests/api/diagrams.ymlNotes for Reviewers
SKETCHI_E2E_EMAIL+SKETCHI_E2E_PASSWORDfor authenticated continuity runs; missing creds are hard failures by design.