Revert fuzzy_lookup optimization and benchmark test#2
Merged
shreejaykurhade merged 1 commit intoshreejaykurhade:mainfrom Apr 11, 2026
Merged
Conversation
This reverts commit bc5b319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit bc5b319 ("Optimize fuzzy_lookup_embedding with numpy vectorized ops") which I accidentally included in your PR against microsoft/typeagent-py.
This removes:
fuzzy_lookup_embedding/fuzzy_lookup_embedding_in_subsetnumpy optimizations fromvectorbase.pytests/benchmarks/test_benchmark_vectorbase.pybenchmark test fileYour auto-tune
MODEL_DEFAULTSchanges andtools/benchmark_embeddings.pyare untouched.After merging, PR microsoft#228 against microsoft/typeagent-py will show only your intended changes. Sorry for the mess!