Conversation
- **Saved Page:** - Redesigned for a two-pane layout in landscape mode, moving floating action buttons to a vertical bar on the side. - **Lyrics Customization Page:** - Now uses a two-column layout on wider screens, showing the lyrics preview and customization options side-by-side. - **Share Page:** - Repositioned the floating action button toolbar to the bottom-right corner in landscape mode for improved accessibility. - **Dialogs & Sheets:** - Adapted the Color Picker Dialog for a more compact, two-column layout in landscape. - Standardized the use of `HorizontalDivider` for better visual separation in bottom sheets (`SharePageSheet`, `SearchSheet`, `LrcCorrectSheet`). - Removed the fixed maximum width on the main screen to allow for better use of space on tablets. - **Refactoring & Minor Fixes:** - Extracted `SavedPageActions` into its own composable for better code organization. - Corrected the layout of action buttons on the Lyrics page, ensuring they appear as individual items.
The key changes include: * Extracting the lyrics preview into a new `LyricsCustomisationPreview` composable. * Extracting the settings controls into a new `lyricsCustomisationSettings` composable. * Using the new composables in `LyricsCustomisationPage` for both portrait and landscape layouts, reducing code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.