Refactor search component styles for improved transitions and visibility#4363
Merged
dimaMachina merged 13 commits intoshuding:mainfrom Apr 10, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: d762b27 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@hichemfantar is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
cc @dimaMachina |
dimaMachina
reviewed
Apr 9, 2025
dimaMachina
reviewed
Apr 9, 2025
dimaMachina
reviewed
Apr 9, 2025
dimaMachina
reviewed
Apr 9, 2025
dimaMachina
reviewed
Apr 10, 2025
dimaMachina
reviewed
Apr 10, 2025
dimaMachina
approved these changes
Apr 10, 2025
Collaborator
dimaMachina
left a comment
There was a problem hiding this comment.
lgtm, nice improvement, addressed 2 comments, and ready to merge!
https://github.com/shuding/nextra/pull/4363/files#r2036306353
https://github.com/shuding/nextra/pull/4363/files#r2036303648
Contributor
Author
|
all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
smooth state transitions
What's being changed (if available, include any code snippets, screenshots, or gifs):
before
Screen.Recording.2025-03-19.at.9.04.07.AM.mp4
after
Screen.Recording.2025-03-19.at.9.03.49.AM.mp4
https://headlessui.com/react/combobox#adding-transitions
Screen.Recording.2025-03-20.at.4.23.22.PM.mp4
Check off the following:
deployment link in this PR's timeline (this link will be available after
opening the PR).