Improve overall accessibility#4365
Conversation
…mproved accessibility
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@hichemfantar is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: b101ff1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clicktodev
changed the title
clicktodev
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
packages/nextra/styles/steps.css
Outdated
| @apply x:before:text-neutral-600 x:dark:before:text-neutral-400; | ||
| @apply x:before:border-gray-200 x:dark:before:border-neutral-700; | ||
| &:before { | ||
| @apply x:absolute x:size-[33px]; | ||
| @apply x:border-4 x:border-nextra-bg; | ||
| @apply x:rounded-full x:text-neutral-400 x:text-base x:font-normal x:text-center x:-indent-px; | ||
| @apply x:border-4; | ||
| @apply x:rounded-full x:text-base x:font-normal x:text-center x:-indent-px; |
There was a problem hiding this comment.
I don't like at all the new steps styling, I prefer to roll back all changes to Steps as well as for Banner
There was a problem hiding this comment.
are you sure, borders for step counters is pretty common https://mantine.dev/core/stepper/
or have a bg instead of a border https://mui.com/material-ui/react-stepper/#linear
There was a problem hiding this comment.
I would prefer to stay with the current "style", minimalistic similar to shadcn https://ui.shadcn.com/docs/components/accordion#installation
dimaMachina
left a comment
dimaMachina
left a comment
There was a problem hiding this comment.
Verified every change in your PR overall LGTM to me, feel free to reply wdyt about my change in #4365 (comment) and feel free to improve bg/text color on steps component #4365 (comment)
And I will merge it! Sorry for taking time to merging your work!
|
lgtm! |
2 participants
Why:
makes text easier to read and achieves WCAG Level AAA compliance in many places
What's being changed (if available, include any code snippets, screenshots, or gifs):
before
after
Check off the following:
deployment link in this PR's timeline (this link will be available after
opening the PR).