Export servers configuration as System property

[slawekjaranowski]

It is possible that build system or other maven plugins can export or log project properties. To avoid presenting sensitive data in public place we can store configuration from servers in System parameters.

[shyiko]

Hi. Could you please specify what kind of build systems / maven plugins do that? Thank you.

[slawekjaranowski]

Maven artifactory plugin deploys build info with all project properties.
Artifactory plugin also can get credential from system property.

I tested this PR with this plugin.

https://www.jfrog.com/confluence/display/RTF/Maven+Artifactory+Plugin
https://www.jfrog.com/confluence/display/RTF/Build+Integration#BuildIntegration-BuildInfoJSON

[shyiko]

I see that you have created a ticket @ jfrog/build-info#64 and to me that seems as a much better way. I also took a quick glance at https://github.com/JFrogDev/build-info/blob/489b8c90484f715b7b0297e757b37669c2da4115/build-info-extractor-maven3/src/main/java/org/jfrog/build/extractor/maven/BuildInfoRecorderLifecycleParticipant.java#L72 and it looks like they also collect system properties which makes the whole thing feel fragile to change (~ reorder). What do you think?

[slawekjaranowski]

Thanks for your investigate.

I don't know how and if is used class mentioned by you but when I tested my change to your extension with artifactory plugin I don't see settings.server in artifactory build info.

Of Course change in artifactory plugin to exclude some properties will be better but I don't know when this will be resolved.

So my change is some workaround for my problem. Maybe some other plugins which I don't know has similar issue.