switch to @checks pragma#448
Closed
vito wants to merge 35 commits into
Closed
Conversation
vito
force-pushed
the
checks-pragma
branch
2 times, most recently
from
e35c4e3 to
c2ab8ad
Compare
shykes
force-pushed
the
checks
branch
2 times, most recently
from
5977c1e to
1933caa
Compare
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
* go back to the regular frontend, we'll adjust from there to get to whatever we want * to clean up the UI, zoom in on a `checks` span, same as shell/prompt-mode does * add support for rolling up logs, re-use 'encapsulate' attribute to mark log roll-up boundaries (TODO: reuse this for 'reveal' boundaries too) * exit nonzero if any checks failed TODO: * we probably just need a bool attr indicating whether a span is a check; sending check name + passed feels redundant w/ span data Signed-off-by: Alex Suraci <alex@dagger.io>
we already moved away with empty => half => full circle, and this looks jazzier anyhow Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
press ctrl+space to sync up the bpm and enter rave mode Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
also start generalizing roll-up; looking to use it to "roll up" spans too by showing dots or something on the span's header line Signed-off-by: Alex Suraci <alex@dagger.io>
fixes rave mode Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
...rather than doing a ton of work at render time. also now we can share this with the web UI. Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
This reverts commit f8271ac.
This reverts commit b435c2f.
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
also, split into two attributes, so you can roll up spans without logs or vice versa plus a minor optimization Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.