New endpoints, mocking utils, CircleCI, merchant / order support, and Python 3 compatibility #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first function added that does not require auth credentials. It is available both on the coinbase module and on CoinbaseAccount.
This allows MOST of the member functions to utilized the updated API Secret method of authentication.
Conflicts: MANIFEST coinbase/__init__.py coinbase/models/error.py setup.py
Collaborator
Author
|
@sibblegp This probably deserves a new release. I'm also getting ready to add "API key + secret" auth (since just using the API key has been deprecated) |
mhluongo
changed the title
Conflicts: coinbase/__init__.py
sibblegp
added a commit
that referenced
this pull request
Oct 11, 2014
New endpoints, mocking utils, CircleCI, merchant / order support, and Python 3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this fork in production for a while, so I think it's good to merge. I've reviewed most of it (though clearly @chris-martin was the author).