[ENH] Add downwards compatibility CI workflow for deep_equals (#532)#1
Open
[ENH] Add downwards compatibility CI workflow for deep_equals (#532)#1
Conversation
Reviewer's GuideAdds a new GitHub Actions workflow that runs targeted deep_equals tests against older NumPy/Pandas dependency combinations using uv with --exclude-newer, triggered on main branch pushes/PRs, weekly schedule, and manual dispatch, with concurrency and matrix-based job configuration. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
uv python install ${{ matrix.python-version }}step doesn’t actually guarantee that Python 3.11 is the interpreter used foruv pip install --systemandpytest(they will likely use the runner’s default Python); consider either usingactions/setup-pythonfor 3.11 or pinning/selecting theuv-managed interpreter explicitly before installing/running tests. - Since all matrix entries currently use the same Python version, you could simplify the matrix by moving
python-version: "3.11"to the job level and only varyingnameandexclude_newerin the matrix, unless you expect to add differing Python versions soon.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `uv python install ${{ matrix.python-version }}` step doesn’t actually guarantee that Python 3.11 is the interpreter used for `uv pip install --system` and `pytest` (they will likely use the runner’s default Python); consider either using `actions/setup-python` for 3.11 or pinning/selecting the `uv`-managed interpreter explicitly before installing/running tests.
- Since all matrix entries currently use the same Python version, you could simplify the matrix by moving `python-version: "3.11"` to the job level and only varying `name` and `exclude_newer` in the matrix, unless you expect to add differing Python versions soon.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
25df238 to
38a4234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes sktime#532.
What does this implement/fix? Explain your changes.
Adds a new GitHub Actions workflow (
.github/workflows/test_compat.yml) that testsdeep_equalsagainst older dependency versions usinguv's--exclude-newerflag:Runs on push/PR to
main, weekly on Mondays, and manually via workflow dispatch.Does your contribution introduce a new dependency? If yes, which one?
No.
uvis already used in the project.What should a reviewer concentrate their feedback on?
python-version: "3.11"is appropriate for both jobsAny other comments?
Existing CI covers numpy 2 + pandas 3. This fills the gap for older combinations legacy users may still rely on.
PR checklist
For all contributions
[CI/CD]For code contributions
Summary by Sourcery
CI: