feat(i18n): add Korean (ko-KR) localization#407
feat(i18n): add Korean (ko-KR) localization#407siddharthvaddem merged 2 commits intosiddharthvaddem:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds Korean (ko-KR) localization: registers Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8af22e96a5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/i18n-check.mjs`:
- Line 14: COMPARE_LOCALES currently omits the French locale causing
`i18n:check` to skip parity validation for French; update the COMPARE_LOCALES
array (the constant named COMPARE_LOCALES in scripts/i18n-check.mjs) to include
"fr" alongside the other locales so French keys are validated for parity the
same as the other entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7f1117c8-64ea-45fd-93cd-8c1c454c1c77
📒 Files selected for processing (9)
scripts/i18n-check.mjssrc/i18n/config.tssrc/i18n/locales/ko-KR/common.jsonsrc/i18n/locales/ko-KR/dialogs.jsonsrc/i18n/locales/ko-KR/editor.jsonsrc/i18n/locales/ko-KR/launch.jsonsrc/i18n/locales/ko-KR/settings.jsonsrc/i18n/locales/ko-KR/shortcuts.jsonsrc/i18n/locales/ko-KR/timeline.json
- Add complete Korean locale across all 7 i18n namespaces - All translation keys match the English baseline 1:1 - Register ko-KR in SUPPORTED_LOCALES and i18n-check validation Refs siddharthvaddem#406
kwakseongjae
force-pushed
the
feat/i18n-ko-KR
branch
from
8af22e9 to
d512f59
Compare
2 participants
Description
Adds complete Korean (ko-KR) locale support across all 7 i18n namespaces.
Motivation
Korean is one of the most widely used languages in developer and creator communities, yet OpenScreen currently has no Korean support. This PR brings Korean-speaking users a fully native experience.
Type of Change
Related Issue(s)
Closes #406
Changes
Config changes
"ko-KR"toSUPPORTED_LOCALESinsrc/i18n/config.ts"ko-KR"to validation scriptscripts/i18n-check.mjsTest plan
npm run i18n:check)References
This PR follows the same pattern as the merged Turkish (#375) and French (#380) locale PRs.
First and foremost — genuine respect and gratitude to @siddharthvaddem and all contributors for building such a thoughtful, well-structured open-source tool. The codebase made this contribution straightforward and enjoyable to work on. Thank you for making this freely available to everyone.
Summary by CodeRabbit