Skip to content

fix: HUD overlay and source selector follow across macOS Spaces#409

Merged
siddharthvaddem merged 2 commits intosiddharthvaddem:mainfrom
Scottlexium:fix/hud-follows-spaces
Apr 11, 2026
Merged

fix: HUD overlay and source selector follow across macOS Spaces#409
siddharthvaddem merged 2 commits intosiddharthvaddem:mainfrom
Scottlexium:fix/hud-follows-spaces

Conversation

@Scottlexium
Copy link
Copy Markdown
Contributor

@Scottlexium Scottlexium commented Apr 10, 2026

Summary

  • Both windows had alwaysOnTop but lacked setVisibleOnAllWorkspaces, causing them to stay pinned to the Space they were opened on
  • Users switching to a different macOS virtual desktop would lose sight of the HUD overlay
  • Added win.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) to both createHudOverlayWindow and createSourceSelectorWindow
  • macOS-only guard — no behaviour change on Windows/Linux

Test plan

  • Open the app, switch to a different macOS Space — HUD should follow
  • Open source selector, switch Space — it should follow
  • Enter a fullscreen app — HUD should remain visible

Summary by CodeRabbit

  • Bug Fixes
    • HUD overlay and source selector windows on macOS now remain accessible across all virtual desktops (Spaces) and full-screen Spaces, preventing them from being pinned to a single workspace and ensuring consistent availability when switching desktops or using full-screen apps.

Both windows had alwaysOnTop but lacked setVisibleOnAllWorkspaces, so
they stayed pinned to the Space they were first opened on. Users moving
to a different virtual desktop would lose sight of the overlay.

Calls setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true })
on macOS only — no-op on Windows/Linux so cross-platform behaviour is
unchanged.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 47fc79c4-5341-4ac3-bfaf-f7da9caa680c

📥 Commits

Reviewing files that changed from the base of the PR and between e7d82e1 and 0bde359.

📒 Files selected for processing (1)
  • electron/windows.ts

📝 Walkthrough

Walkthrough

The PR adds macOS-specific visibility calls to two window-creation functions in electron/windows.ts, invoking win.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) when process.platform === "darwin" so the HUD overlay and source-selector windows appear on all Spaces. No other logic or API surfaces changed.

Changes

Cohort / File(s) Summary
macOS Window Visibility
electron/windows.ts
Added setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true }) to createHudOverlayWindow() and createSourceSelectorWindow() under a macOS platform check so those windows persist across virtual desktops (Spaces).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

windows slip through darwin's doors,
floating gently across the boards,
hud and selector, not stuck in place,
they follow users from space to space —
kinda elegant, lowkey magic ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding macOS Spaces-following behavior to HUD overlay and source selector windows.
Description check ✅ Passed The description covers Summary, Test plan, and implementation details, though it deviates from the template structure and lacks explicit sections like Type of Change and Related Issue.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@siddharthvaddem siddharthvaddem merged commit 5781be0 into siddharthvaddem:main Apr 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants