Skip to content

Conversation

@polomarcus
Copy link
Collaborator

Add remaining percentage of the coutdown.
Works with :

  • coutdown
  • end-time

screen shot 2015-03-26 at 13 49 01

@polomarcus
Copy link
Collaborator Author

The gh-pages might not like this PR because of _timer.jsin index.html

    <script src="app/js/_timer.js"></script>
    <script src="app/js/i18nService.js"></script>
    <script src="app/js/progressBarService.js"></script>

I will make a PR to use https://github.com/tschaub/grunt-gh-pages and facilitate all of this

index.html Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be deleted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddii I think I am going to create a angular-timer-all.js for index.html that could be used in the gh-pages and for #168

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure... Sounds good to me :)
On Thu, Mar 26, 2015 at 4:37 PM Paul Leclercq notifications@github.com
wrote:

In index.html
#171 (comment):

@@ -14,7 +14,10 @@
<script src="bower_components/momentjs/min/moment.min.js"></script>
<script src="bower_components/momentjs/min/locales.min.js"></script>
<script src="bower_components/humanize-duration/humanize-duration.js"></script>

  • <script src="dist/angular-timer.js"></script>

@siddii https://github.com/siddii I think I am going to create a
angular-timer-all.js for index.html that could be used in the gh-pages and
for #168 #168


Reply to this email directly or view it on GitHub
https://github.com/siddii/angular-timer/pull/171/files#r27258707.

@polomarcus
Copy link
Collaborator Author

With this new grunt work flow we have :

Beware with /index.html the examples page will not work, as they are not essential to the dev phase. The examples works for dist/index.html

siddii added a commit that referenced this pull request Mar 30, 2015
@siddii siddii merged commit 0e8626c into siddii:master Mar 30, 2015
@AaronBuxbaum
Copy link

@siddii I think you need to also update your demo page, since this change breaks it. Looks good though, going to try it out tonight!

@polomarcus
Copy link
Collaborator Author

Sorry, i forget to include the gh-pages grunt task in my PR: #172

@polomarcus
Copy link
Collaborator Author

http://siddii.github.io/angular-timer/ updated with gh-pages grunt task

@siddii
Copy link
Owner

siddii commented Mar 30, 2015

Awesome.. 👍 Thanks @polomarcus, you rock!

@polomarcus
Copy link
Collaborator Author

No, no, no, you rock! haha

@AaronBuxbaum
Copy link

Works perfectly for my purposes (though I think the demo page is missing a binding to the 'active' progress bar); thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants