-
Notifications
You must be signed in to change notification settings - Fork 934
Feature Progress bar #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Progress bar #171
Conversation
|
The gh-pages might not like this PR because of <script src="app/js/_timer.js"></script>
<script src="app/js/i18nService.js"></script>
<script src="app/js/progressBarService.js"></script>I will make a PR to use https://github.com/tschaub/grunt-gh-pages and facilitate all of this |
index.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure... Sounds good to me :)
On Thu, Mar 26, 2015 at 4:37 PM Paul Leclercq notifications@github.com
wrote:
In index.html
#171 (comment):@@ -14,7 +14,10 @@
<script src="bower_components/momentjs/min/moment.min.js"></script>
<script src="bower_components/momentjs/min/locales.min.js"></script>
<script src="bower_components/humanize-duration/humanize-duration.js"></script>
- <script src="dist/angular-timer.js"></script>
@siddii https://github.com/siddii I think I am going to create a
angular-timer-all.js for index.html that could be used in the gh-pages and
for #168 #168—
Reply to this email directly or view it on GitHub
https://github.com/siddii/angular-timer/pull/171/files#r27258707.
|
With this new grunt work flow we have :
Beware with /index.html the examples page will not work, as they are not essential to the dev phase. The examples works for dist/index.html |
|
@siddii I think you need to also update your demo page, since this change breaks it. Looks good though, going to try it out tonight! |
|
Sorry, i forget to include the gh-pages grunt task in my PR: #172 |
|
http://siddii.github.io/angular-timer/ updated with gh-pages grunt task |
|
Awesome.. 👍 Thanks @polomarcus, you rock! |
|
No, no, no, you rock! haha |
|
Works perfectly for my purposes (though I think the demo page is missing a binding to the 'active' progress bar); thanks a lot! |
Add remaining percentage of the coutdown.
Works with :