fix: prevent concurrent JSON write corruption#71
Open
charu2210 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented atomic JSON persistence to prevent corruption during concurrent writes and interrupted save operations.
Changes Made
Added
atomic_json_write()helper using temporary files +os.replace()Added thread locking for JSON persistence operations
Updated:
save_command_history()clear_command_history()save_workspace_state()Added safer recovery handling for corrupted workspace state files
Issue Fixed
Previously, direct concurrent writes to JSON state/history files could result in:
The new implementation ensures writes are atomic and thread-safe.
Fixes #63