[macos] fix Tab navigation in new worktree sheet#14
Merged
nicosuave merged 1 commit intosidequery:mainfrom Feb 26, 2026
Merged
Conversation
The Toggle in CreateWorktreeSheet was not reachable via Tab because SwiftUI does not include Toggle in the keyboard focus cycle by default on macOS. Adding .focusable() lets Tab traverse Branch → Base → Create branch → Cancel → Create. Made-with: Cursor
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.focusable()to the Toggle so the full Tab cycle works: Branch → Base → Create branch → Cancel → Create.Changes
.focusable()modifier on the Toggle inCreateWorktreeSheet. SwiftUI on macOS doesn't include Toggle in the keyboard focus cycle by default.Testing
Did this cause any problems?
Rollback/revert this commit and redeploy the service.
Made with Cursor