Merged
Conversation
The "tabs" and "hidden" macos-titlebar-style values don't work with the Worktrunk sidebar. "tabs" installs its own toolbar without a sidebar tracking separator, causing the sidebar to be truncated by the toolbar. "hidden" removes the titlebar entirely, losing the sidebar toggle button. Override both to use the "transparent" titlebar, which properly installs the WorktrunkToolbar with a sidebarTrackingSeparator. Fixes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-titlebar-style = tabsandhiddento use thetransparenttitlebar nib insteadtabsstyle installs its own toolbar without asidebarTrackingSeparator, causing the Worktrunk sidebar to be truncated by the toolbar/tab bar regionhiddenstyle removes the titlebar entirely, losing the sidebar toggle buttontransparent, which properly installs theWorktrunkToolbarwith sidebar trackingFixes #27