Add adapter compatibility docs for LookML, Cube, OSI, and Malloy#109
Add adapter compatibility docs for LookML, Cube, OSI, and Malloy#109
Conversation
Comprehensive feature-by-feature documentation of what each adapter supports, partially supports, or does not support when importing from these semantic layer formats.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63801aefb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `source: name is base -> { ... } extend { ... }` (pipeline source) | Partial support: the extend block is processed but the arrow pipeline query is not evaluated. The model has no table and only contains fields from the extend block. | | ||
| | `source: name is compose(...)` (composite sources) | Partial support: parses without error but the composition logic is not evaluated. No fields are extracted from the composed sources. | | ||
| | `source()` (parameterized sources) | Partial support: parameters are parsed by the grammar but parameter values are not stored or substituted. | | ||
| | Old `+` syntax for extending (`base + { ... }`) | Partial support: the grammar parses this as `SQRefinedQuery`. The extend block is not processed, only the base source reference. | |
There was a problem hiding this comment.
+ source extension as unsupported
The compatibility table says source: name is base + { ... } keeps the base source reference, but the adapter never handles SQRefinedQuery in MalloyModelVisitor._process_sq_expr (it only branches on SQTable, SQSQL, SQExtendedSource, SQInclude, SQID, and SQParens). For Malloy files using the legacy + form, this means neither the base source nor refinement block is actually applied, so users can end up with models missing table/sql and extracted fields despite docs claiming partial support.
Useful? React with 👍 / 👎.
1 participant
Summary
docs/compatibility/with feature-by-feature compatibility documentation for the LookML, Cube, OSI, and Malloy adapters.