Skip to content

Improve Malloy adapter: docs, join direction, kitchen sink tests#114

Merged
nicosuave merged 1 commit intomainfrom
nicosuave/malloy-adapter-improve
Mar 28, 2026
Merged

Improve Malloy adapter: docs, join direction, kitchen sink tests#114
nicosuave merged 1 commit intomainfrom
nicosuave/malloy-adapter-improve

Conversation

@nicosuave
Copy link
Copy Markdown
Member

Summary

  • Restructure Malloy compat doc (lines 174-328) to use table-based format matching LookML/Cube/OSI docs, removing prose paragraphs and parser internal references (SQInclude, SQRefinedQuery)
  • Store join direction modifiers (LEFT/RIGHT/FULL/INNER) in metadata["join_direction"] on relationships, matching how LookML stores join_type
  • Add kitchen sink integration test: 8-source e-commerce Malloy model with 39 DuckDB-backed tests covering all measure types, filtered measures, dimension queries, cross-model joins, and segments
  • Add expression transform tests: 9 fixture-based tests verifying ??->COALESCE, @date->DATE literals, &->AND expansion, pick/when->CASE, now->CURRENT_TIMESTAMP

…ests

Restructure compat doc to match table-based format of other adapter docs,
removing prose paragraphs and parser internals. Store join direction
(LEFT/RIGHT/FULL/INNER) in relationship metadata. Add kitchen sink
integration test with DuckDB and expression transform tests.
@nicosuave nicosuave merged commit 9023e2a into main Mar 28, 2026
15 checks passed
@nicosuave nicosuave deleted the nicosuave/malloy-adapter-improve branch March 28, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant