Reorganize adapter tests into per-adapter folders#14
Merged
Conversation
Merge test_<adapter>_roundtrip.py files into test_<adapter>.py for each adapter: - Cube, MetricFlow, LookML, Hex, Rill, Superset, Omni Changes: - Organize each test file with clear sections: PARSING, ROUNDTRIP, CROSS-FORMAT CONVERSION, SIDEMANTIC CONVERSION, QUERY - Distribute tests from test_export_adapters.py into test_cube.py and test_metricflow.py - Rename test_sidemantic_adapter.py to test_sidemantic.py for consistency - Remove redundant duplicate tests that existed across files All 156 adapter tests pass. Net reduction of 7 tests (all were duplicates).
Split monolithic test files into folder structure: - tests/adapters/cube/ (parsing, roundtrip, conversion, query) - tests/adapters/hex/ (parsing, roundtrip, conversion, query) - tests/adapters/lookml/ (parsing, roundtrip, conversion, query) - tests/adapters/metricflow/ (parsing, roundtrip, conversion, query) - tests/adapters/omni/ (parsing, roundtrip, conversion) - tests/adapters/rill/ (parsing, roundtrip, conversion, query) - tests/adapters/sidemantic_adapter/ (parsing) - tests/adapters/superset/ (parsing, roundtrip, conversion) Each adapter now has dedicated test files by test type for better organization and maintainability.
nicosuave
force-pushed
the
test-reorganization
branch
from
3924ef3 to
3fd2162
Compare
nicosuave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/adapters/:cube/- test_parsing.py, test_roundtrip.py, test_conversion.py, test_query.pyhex/- test_parsing.py, test_roundtrip.py, test_conversion.py, test_query.pylookml/- test_parsing.py, test_roundtrip.py, test_conversion.py, test_query.pymetricflow/- test_parsing.py, test_roundtrip.py, test_conversion.py, test_query.pyomni/- test_parsing.py, test_roundtrip.py, test_conversion.pyrill/- test_parsing.py, test_roundtrip.py, test_conversion.py, test_query.pysidemantic_adapter/- test_parsing.pysuperset/- test_parsing.py, test_roundtrip.py, test_conversion.pybsl/- test_parsing.py, test_roundtrip.pyAll 782 tests pass (rebased onto main).