Fix null safety in all semantic layer adapters#18
Merged
Conversation
Change .get("key", []) to .get("key") or [] pattern across all adapters
to handle YAML files with explicit empty sections (key: with no value)
which parse as None instead of missing keys.
Affected adapters: MetricFlow, LookML, Hex, Sidemantic, Superset, Rill, Omni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same fix from the Cube adapter (#16) to all other semantic layer adapters.
Problem: When YAML has explicit empty sections like
dimensions:with no value, it parses asNoneinstead of a missing key. Using.get("key", [])returnsNone(not the default[]), causingTypeError: 'NoneType' object is not iterable.Fix: Change
.get("key", [])to.get("key") or []which handles both missing keys and explicitNonevalues.Affected adapters:
All 196 adapter tests pass.