Move default_time_dimension from Metric to Model#8
Merged
Conversation
3bfc48d to
cd9139c
Compare
cd9139c to
dc6c05f
Compare
Breaking change: default_time_dimension and default_grain are now model-level settings, not per-metric. This aligns with MetricFlow's approach where all metrics in a semantic model share the same default time dimension. When a model has default_time_dimension set and no time dimension from that model is in the query, auto-include it. Also applies default_grain if specified. User-provided time dimensions override the default.
dc6c05f to
be69572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change:
default_time_dimensionanddefault_grainare now model-level settings, not per-metric.This aligns with MetricFlow's approach (
defaults.agg_time_dimension) where all metrics in a semantic model share the same default time dimension.Changes
default_time_dimensionanddefault_grainfromMetricdefault_time_dimensionanddefault_graintoModeldefaults.agg_time_dimensionExample