Skip to content

Handle DROP VIEW cleanup and robust SQL parser spans #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosuave merged 2 commits into from
Feb 21, 2026
Merged

Handle DROP VIEW cleanup and robust SQL parser spans #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f928e
Handle DROP VIEW cleanup and parser span fixes
nicosuave Feb 21, 2026
7c54713
Fix parse_select SQL length handling
nicosuave Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/yardstick_ffi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ struct YardstickMeasureAggResult {

bool yardstick_has_as_measure(const char* sql);
bool yardstick_has_aggregate(const char* sql);
bool yardstick_drop_measure_view_from_sql(const char* sql);
bool yardstick_has_curly_brace(const char* sql);
bool yardstick_has_at_syntax(const char* sql);

Expand Down
5 changes: 5 additions & 0 deletions src/yardstick_extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ extern "C" {
extern "C" {
bool yardstick_has_as_measure(const char *sql);
bool yardstick_has_aggregate(const char *sql);
bool yardstick_drop_measure_view_from_sql(const char *sql);
YardstickCreateViewResult yardstick_process_create_view(const char *sql);
YardstickAggregateResult yardstick_expand_aggregate(const char *sql);
void yardstick_free(char *ptr);
Expand Down Expand Up @@ -338,6 +339,10 @@ ParserExtensionParseResult yardstick_parse(ParserExtensionInfo *,
sql_to_check = semantic_stripped;
}

if (yardstick_drop_measure_view_from_sql(sql_to_check.c_str())) {
return ParserExtensionParseResult();
}

// Check for AGGREGATE() function
if (yardstick_has_aggregate(sql_to_check.c_str())) {
YardstickAggregateResult result = yardstick_expand_aggregate(sql_to_check.c_str());
Expand Down
Loading
Loading