-
Notifications
You must be signed in to change notification settings - Fork 0
Add parser_override to eliminate SEMANTIC prefix requirement #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dbb7c0a
Add parser_override to eliminate SEMANTIC prefix requirement
nicosuave cfd15a3
Handle quoted identifiers in AGGREGATE() argument extraction
nicosuave bfafe8d
Return parsed statements directly for non-SELECT to preserve transact…
nicosuave 5ce29d6
Allow whitespace in qualified measure refs like AGGREGATE(s . revenue)
nicosuave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
yardstick_expand_aggregatereturns an error, this branch always falls back to DuckDB's native parser, which leaves the original SQL unchanged. That breaks the new non-SEMANTICpath for statement types likeCREATE TABLE ... AS SELECTandINSERT ... SELECT:expand_aggregatestill relies onparse_select, andyardstick_parse_selectexplicitly rejects non-SELECTtop-level statements (src/yardstick_parser_ffi.cpparound lines 1098-1100), so these queries are never rewritten and end up failing on DuckDB's built-inaggregatefunction instead of executing Yardstick semantics.Useful? React with 👍 / 👎.