Skip to content

Conversation

@faizanu94
Copy link

Checklist for Pull Requests

  • All tests pass (yarn test:all and yarn test:integration)
  • Code follows the style guide and passes lint checks
  • Documentation is updated (README, docs, etc)
  • Linked to corresponding issue, if applicable

Summary of Changes

This PR adds support for overriding the start path when using manual job resolution in Sidequest:

  • Introduced a new config option paths.start in EngineConfig.
  • Updated findSidequestJobsScriptInParentDirs to resolve from explicit override before falling back to existing upward directory search.
  • Added unit tests for start path override.
  • Updated Manual Job Resolution docs to explain how to use paths.start with build outputs.

This enables projects that transpile or emit sidequest.jobs.js to custom build directories to cleanly configure job resolution without patching the engine.

Closes #108

@GiovaniGuizzo
Copy link
Contributor

Thanks for the contribution.

However, that doesn't quite solve the problem. The main problem is that we are using process.pwd(), thus if Sidequest is included in a project which in turn is used as a library, the manual resolution will not work even if you set that path.

I will work on another PR for a different strategy. The idea is to get a relative path to the file that called Sidequest.start.

@faizanu94
Copy link
Author

Closing in favor of #111 which addresses the root issue.

@faizanu94 faizanu94 closed this Oct 6, 2025
@sidequest-release
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow customizing start path for manual job resolution

2 participants