-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add dashboard base path #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for configuring a base path for the Sidequest dashboard when serving it behind a reverse proxy. This allows the dashboard to be mounted at a custom path prefix (e.g., /admin/sidequest) instead of only being available at the root path.
- Adds
basePathconfiguration option toDashboardConfiginterface - Updates all template files to use the base path variable for URLs and asset references
- Modifies route setup and static file serving to respect the configured base path
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/docs/dashboard.md | Documents the new basePath configuration option and reverse proxy setup |
| packages/dashboard/src/config.ts | Adds basePath property to DashboardConfig interface with comprehensive documentation |
| packages/dashboard/src/index.ts | Implements basePath normalization and applies it to routes and static assets |
| packages/dashboard/src/views/layout.ejs | Updates navigation links and asset references to use basePath |
| packages/dashboard/src/views/partials/*.ejs | Updates HTMX endpoints and action URLs to include basePath |
| packages/dashboard/src/views/pages/*.ejs | Updates script sources and form targets to use basePath |
| packages/dashboard/src/public/js/dashboard.js | Updates fetch URL to use basePath from global variable |
| packages/dashboard/README.md | Adds reverse proxy configuration documentation with nginx example |
| examples/06-dashboard-base-path/ | Provides working example demonstrating basePath functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# [1.12.0](v1.11.0...v1.12.0) (2025-10-28) ### Features * add dashboard base path ([#119](#119)) ([4730c46](4730c46))
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Checklist for Pull Requests
yarn test:allandyarn test:integration)Summary of Changes
Closes #103