Skip to content

Conversation

@GiovaniGuizzo
Copy link
Contributor

Checklist for Pull Requests

  • All tests pass (yarn test:all and yarn test:integration)
  • Code follows the style guide and passes lint checks
  • Documentation is updated (README, docs, etc)
  • Linked to corresponding issue, if applicable

Summary of Changes

This PR fixes a bug where the stale job cleanup would not honor the max_attempts of a job. It would then cause Sidequest to keep re-executing stale jobs forever.

Closes #155

@GiovaniGuizzo GiovaniGuizzo merged commit f85e592 into master Jan 26, 2026
6 checks passed
@GiovaniGuizzo GiovaniGuizzo deleted the fix/stale-job-max-attempt branch January 26, 2026 23:39
sidequest-release bot pushed a commit that referenced this pull request Jan 26, 2026
## [1.13.5](v1.13.4...v1.13.5) (2026-01-26)

### Bug Fixes

* enhance stale job handling with JobTransitioner and improve test coverage ([#157](#157)) ([f85e592](f85e592))
@sidequest-release
Copy link

🎉 This PR is included in version 1.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

max_retries doesn't always apply

3 participants