feat: consolidate extension services#962
Merged
talos-bot merged 1 commit intosiderolabs:mainfrom Feb 19, 2026
Merged
Conversation
Consolidate extension services to be self contained, don't pollute rootfs or mount up libraries from host unless absolutely needed. Fixes: siderolabs#876 Fixes: siderolabs/talos#12667 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
force-pushed
the
feat/consolidate-shared-libraries
branch
from
927bdc7 to
fb4eb04
Compare
dsseng
approved these changes
Feb 18, 2026
Member
dsseng
left a comment
dsseng
left a comment
There was a problem hiding this comment.
Looks great, haven't tested anything but looks much more ordered now
| - | | ||
| @$(MAKE) docker-test-extension TARGET_ARGS="--tag=$(REGISTRY)/$(USERNAME)/$@:v0 --push=$(PUSH)" TEST_STAGE=$* | ||
| @docker pull $(REGISTRY)/$(USERNAME)/$@:v0 | ||
| @orb debug $(REGISTRY)/$(USERNAME)/$@:v0 |
Member
There was a problem hiding this comment.
Could there be a way to do this with Docker or another Linux tool?
Member
There was a problem hiding this comment.
Perhaps BUILDX_EXPERIMENTAL=1 docker buildx debug build?
Member
Author
There was a problem hiding this comment.
it won't since our images don't have shell, orb debug uses a nix environment which is self contained at /nix so just set PATH to /nix and everything works, I wished we could, or hack around with a readymade nix image
Member
Author
|
/m |
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Feb 19, 2026
Refactoring in siderolabs#962 missed copying the iscsi extension manifest. Signed-off-by: Noel Georgi <git@frezbo.dev>
Merged
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Feb 20, 2026
This was an oversight and was missed while doing siderolabs#962 See also siderolabs#988 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Feb 20, 2026
This was an oversight and was missed while doing siderolabs#962 See also siderolabs#988 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/extensions
that referenced
this pull request
Feb 20, 2026
This was an oversight and was missed while doing siderolabs#962 See also siderolabs#988 Signed-off-by: Noel Georgi <git@frezbo.dev>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate extension services to be self contained, don't pollute rootfs or mount up libraries from host unless absolutely needed.
Fixes: #876
Fixes: siderolabs/talos#12667