Skip to content

feat(nvidia): switch to CDI#996

Merged
talos-bot merged 1 commit intosiderolabs:mainfrom
frezbo:feat/nvidia-cdi
Mar 10, 2026
Merged

feat(nvidia): switch to CDI#996
talos-bot merged 1 commit intosiderolabs:mainfrom
frezbo:feat/nvidia-cdi

Conversation

@frezbo
Copy link
Member

@frezbo frezbo commented Mar 5, 2026

Switch to CDI for NVIDIA.

Fixes: #940
Fixes: siderolabs/talos#12103

Needs: siderolabs/talos#12909

Switch to CDI for NVIDIA.

Fixes: siderolabs#940
Fixes: siderolabs/talos#12103

Needs: siderolabs/talos#12909

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo frezbo marked this pull request as ready for review March 10, 2026 09:49
@github-project-automation github-project-automation bot moved this to To Do in Planning Mar 10, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Mar 10, 2026
@github-project-automation github-project-automation bot moved this from In Review to Approved in Planning Mar 10, 2026
entrypoint: ./qemu-ga
mounts:
# State files.
- source: /system/run/qemu-guest-agent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it correct change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, intentional

Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we have the same final list extensions still? so users upgrading to 1.13 don't need to worry about this?

@smira
Copy link
Member

smira commented Mar 10, 2026

My question was more like - what does it change? We still ship NVIDIA's runtime class?

@frezbo
Copy link
Member Author

frezbo commented Mar 10, 2026

@

so we have the same final list extensions still? so users upgrading to 1.13 don't need to worry about this?

yes, only thing is they need to uninstall device plugin and install the gpu operator

@frezbo
Copy link
Member Author

frezbo commented Mar 10, 2026

@

so we have the same final list extensions still? so users upgrading to 1.13 don't need to worry about this?

yes, only thing is they need to uninstall device plugin and install the gpu operator

well that's what nvidia recommends too

@frezbo
Copy link
Member Author

frezbo commented Mar 10, 2026

My question was more like - what does it change? We still ship NVIDIA's runtime class?

we still ship it, but no need to configure runtimeclass manually anymore

@frezbo
Copy link
Member Author

frezbo commented Mar 10, 2026

/m

@talos-bot talos-bot merged commit c5480f9 into siderolabs:main Mar 10, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Planning Mar 10, 2026
@frezbo frezbo deleted the feat/nvidia-cdi branch March 10, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

4 participants