Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/parsers/binary_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,11 @@
field.columnType
)
) {
return packet.readDateTimeString(parseInt(field.decimals, 10));
return packet.readDateTimeString(
parseInt(field.decimals, 10),
' ',
field.columnType
);

Check warning on line 118 in lib/parsers/binary_parser.js

View check run for this annotation

Codecov / codecov/patch

lib/parsers/binary_parser.js#L114-L118

Added lines #L114 - L118 were not covered by tests
}

if (field.columnType === Types.TINY) {
Expand Down
4 changes: 3 additions & 1 deletion lib/parsers/static_binary_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@ function getBinaryParser(fields, _options, config) {
].includes(field.columnType)
) {
return packet.readDateTimeString(
parseInt(field.decimals, 10)
parseInt(field.decimals, 10),
' ',
field.columnType
);
}

Expand Down
37 changes: 37 additions & 0 deletions test/esm/integration/parsers/typecast-field-datetime.test.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { describe, assert } from 'poku';
import { createRequire } from 'node:module';

const require = createRequire(import.meta.url);
const {
createConnection,
describeOptions,
} = require('../../../common.test.cjs');

const conn = createConnection({
typeCast: (field) => field.string(),
}).promise();

describe('typeCast field.datetime', describeOptions);

const query = {};
const execute = {};

await conn.query('CREATE TEMPORARY TABLE `tmp_date` (`datetime` DATETIME)');

await conn.query('INSERT INTO `tmp_date` (`datetime`) VALUES (CURRENT_DATE())');

{
const [date] = await conn.execute('SELECT datetime from tmp_date');

execute.date = date[0].datetime;
}

{
const [date] = await conn.query('SELECT datetime from tmp_date');

query.date = date[0].datetime;
}

await conn.end();

assert.equal(execute.date, query.date, 'DATETIME');