Extract declare constraints using the built state (if this is available)#2
Merged
balaktsis merged 10 commits intotrace_id_stringfrom Jan 27, 2025
Merged
Extract declare constraints using the built state (if this is available)#2balaktsis merged 10 commits intotrace_id_stringfrom
balaktsis merged 10 commits intotrace_id_stringfrom
Conversation
added 10 commits
December 6, 2024 09:57
…omaticallyr ead and convert parquet to objects.
…e/constraint) - by comparing it with the mining one, and got correct results
…the same results, despite using or not the built state. Some comments are missing but can be added in latter state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the declare queries to adhere to the structure of the other queries. That is I used the structure QueryWrapper -> Query -> QueryPlan -> QueryResponse.
Based on the updated structure I added the logic to extract the Declare constraints by utilizing the built state.
The QP will always use the state of it is available, and will append some statistics (e.g., if the state is up to date, and if not what percentage of the total traces and events exist in the state). This will allow users to get a good answer even if the state is not up to date. Finally, the user can choose to force the mining process by setting the "enforceNormalMining" parameter to true in any of the Declare queries.