Skip to content

rust(feat): Remove deprecated recovery strategies#333

Merged
tsift merged 3 commits into
mainfrom
tsift/rust/remove-deprecated-recovery-strategies
Oct 2, 2025
Merged

rust(feat): Remove deprecated recovery strategies#333
tsift merged 3 commits into
mainfrom
tsift/rust/remove-deprecated-recovery-strategies

Conversation

@tsift
Copy link
Copy Markdown
Contributor

@tsift tsift commented Oct 1, 2025

Removes previously deprecated recovery strategies RecoveryStrategy::RetryWithInMemoryBackups and RecoveryStrategy::RetryWithDiskBackups.

With the removal of these strategies, the SiftStream:: backups_manager member has also been simplified to the single backup manager type (though still optional based on recovery strategy).

@tsift tsift requested a review from nathan-sift October 1, 2025 18:19
Copy link
Copy Markdown
Contributor

@nathan-sift nathan-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the docs in src/lib.rs

Comment thread rust/crates/sift_stream/src/backup/disk/mod.rs Outdated
@tsift
Copy link
Copy Markdown
Contributor Author

tsift commented Oct 2, 2025

We should also update the docs in src/lib.rs

Updated in 0cfe75f

Copy link
Copy Markdown
Contributor

@nathan-sift nathan-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tsift tsift merged commit 39cfddb into main Oct 2, 2025
8 checks passed
@tsift tsift deleted the tsift/rust/remove-deprecated-recovery-strategies branch October 2, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants