Skip to content

Python(feat): Remote Files API#366

Merged
andrew-siftstack merged 135 commits into
mainfrom
python/remote_files
Nov 26, 2025
Merged

Python(feat): Remote Files API#366
andrew-siftstack merged 135 commits into
mainfrom
python/remote_files

Conversation

@andrew-siftstack
Copy link
Copy Markdown
Contributor

@andrew-siftstack andrew-siftstack commented Nov 5, 2025

Added Remote Files API to the python client.

Comment thread python/lib/sift_client/sift_types/file_attachment.py
Comment thread python/lib/sift_client/_internal/low_level_wrappers/remote_files.py
Copy link
Copy Markdown
Contributor

@ian-sift ian-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly good to me. Just should add some tests to help verifyh

@ian-sift ian-sift requested review from alexluck-sift and ian-sift and removed request for ian-sift November 5, 2025 20:46
@alexluck-sift
Copy link
Copy Markdown
Collaborator

Since this is adding support for file attachments, we should integrate it with the resource(s) that have file attachments directly.

Additionally, what would a good pattern be for adding/removing attachments be? Downloading them?

For example:

run = sift_client.runs.get(...)
attachments = run.attachments

Comment thread python/lib/sift_client/client.py Outdated
Comment thread python/lib/sift_client/resources/remote_files.py Outdated
Comment thread python/lib/sift_client/resources/remote_files.py Outdated
Comment thread python/lib/sift_client/sift_types/remote_file.py Outdated
Comment thread python/lib/sift_client/_internal/low_level_wrappers/remote_files.py
Comment thread python/lib/sift_client/resources/file_attachments.py Outdated
@alexluck-sift
Copy link
Copy Markdown
Collaborator

I made this PR to suggest the list_ changes and identified a fix for the missing mixin methods:
#393

Comment thread python/lib/sift_client/resources/file_attachments.py Outdated
Comment thread python/lib/sift_client/_internal/low_level_wrappers/remote_files.py Outdated
Comment thread python/lib/sift_client/resources/file_attachments.py Outdated
Comment thread python/lib/sift_client/_internal/low_level_wrappers/remote_files.py Outdated
@alexluck-sift alexluck-sift self-requested a review November 25, 2025 19:28
Copy link
Copy Markdown
Collaborator

@alexluck-sift alexluck-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrew-siftstack andrew-siftstack merged commit d57788b into main Nov 26, 2025
15 checks passed
@andrew-siftstack andrew-siftstack deleted the python/remote_files branch November 26, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants