rust(bug): Improve how sift-stream handles the flow config cache#401
Merged
Conversation
nathan-sift
requested changes
Nov 24, 2025
nathan-sift
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves how sift-stream handles the flow config cache internally.
Note, the initialization behavior w/r/t Sift is unchanged, sift-stream simply no longer will throw away the resulting flow configs when none are provided during initialization.
These changes improve the restart behavior of sift-stream or restarts of upstream callers. For example, if an upstream entity is responsible for streaming flow "foo" and always attempts to add flow "foo" when starting, that entity disconnecting and reconnecting would previously always hit an "already exists" error for subsequent calls to "add_new_flow". The same scenario would occur if sift-stream itself needed to be recreated, since effectively the upstream entity would perform the same actions.