rust(feat/bug): Improve add flow config, prevent send_impl error#409
Merged
Conversation
nathan-sift
requested changes
Nov 26, 2025
nathan-sift
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if the ingestion and the backup channel were full, an error would be returned by
send_implwhich could impact ingestion for callers if unhandled. Following the previous pattern of not returning the error when the backup channel is full, this scenario will also no longer result in an error. Instead the code path will be tracked with a new metric and logging available at the debug level (to avoid spamming console logs).Additionally, to speed up adding new flows, calls will be multiplexed concurrently, waiting for all to complete before proceeding.