Skip to content

rust(feat): Adds a new SiftStream mode for only backup file writes#416

Merged
tsift merged 8 commits into
mainfrom
rust/new-sift-stream-mode-to-only-write-backup-files
Dec 5, 2025
Merged

rust(feat): Adds a new SiftStream mode for only backup file writes#416
tsift merged 8 commits into
mainfrom
rust/new-sift-stream-mode-to-only-write-backup-files

Conversation

@tsift

@tsift tsift commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

In order to support a SiftStreamMode that only writes data to backup files, a bit of refactoring is also included in this PR. The set of changes includes:

  • Moving code shared between the IngestionConfigMode and FileBackupMode implementations to common locations (either moving internal state up to SiftStream itself, or simply shared modules).
  • Moving some file writing implementations to shared locations for use between FileBackupMode and AsyncBackupManager.
  • The SiftStreamMode trait was expanded for the various send APIs and was "sealed". The API that will be interacted with by users of the crate will be those on SiftStream itself now, while the "mode" implementations are internal details (though technically public due to the generic type in SiftStream).

Documentation was updated, including a new example which uses the new SiftStreamMode (I also added example for using the FlowBuilder into both).

Finally, I also went through and updated some pub items to pub(crate).

@tsift tsift requested a review from nathan-sift December 2, 2025 22:34
@tsift tsift force-pushed the rust/new-sift-stream-mode-to-only-write-backup-files branch from 01c290e to ad9f117 Compare December 2, 2025 23:50
Comment thread rust/crates/sift_stream/README.md Outdated
Comment thread rust/crates/sift_stream/src/stream/builder.rs
@tsift tsift requested a review from nathan-sift December 4, 2025 19:22

@nathan-sift nathan-sift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the new <Encoder, Transport> looks good, and should hopefully be easier to extend in the future.

@tsift tsift merged commit b8f13b2 into main Dec 5, 2025
13 checks passed
@tsift tsift deleted the rust/new-sift-stream-mode-to-only-write-backup-files branch December 5, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants