rust(feat): Adds a new SiftStream mode for only backup file writes#416
Merged
Merged
Conversation
01c290e to
ad9f117
Compare
nathan-sift
requested changes
Dec 3, 2025
nathan-sift
approved these changes
Dec 5, 2025
nathan-sift
left a comment
Contributor
There was a problem hiding this comment.
Nice, the new <Encoder, Transport> looks good, and should hopefully be easier to extend in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support a
SiftStreamModethat only writes data to backup files, a bit of refactoring is also included in this PR. The set of changes includes:IngestionConfigModeandFileBackupModeimplementations to common locations (either moving internal state up toSiftStreamitself, or simply shared modules).FileBackupModeandAsyncBackupManager.SiftStreamModetrait was expanded for the varioussendAPIs and was "sealed". The API that will be interacted with by users of the crate will be those onSiftStreamitself now, while the "mode" implementations are internal details (though technically public due to the generic type inSiftStream).Documentation was updated, including a new example which uses the new
SiftStreamMode(I also added example for using theFlowBuilderinto both).Finally, I also went through and updated some
pubitems topub(crate).