Skip to content

rust(feat): Rename ingestion_config for python linting #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsift merged 1 commit into from
May 7, 2026
Merged

rust(feat): Rename ingestion_config for python linting #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/crates/sift_stream_bindings/sift_stream_bindings.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ class SiftStreamBuilderPy:
r"""
Whether TLS is enabled. Defaults to `True`. Set to `False` for local testing only.
"""
ingestion_config: typing.Optional[IngestionConfigFormPy]
ingestion_config_form: typing.Optional[IngestionConfigFormPy]
r"""
Ingestion config form. Must be set before calling [`build()`][SiftStreamBuilderPy::build].
"""
Expand Down Expand Up @@ -567,7 +567,7 @@ class SiftStreamBuilderPy:

This is the quick path: `ingestion_config` must be set; all other fields are optional.
For other modes (checkpointing, disk backups, tunable capacities), use
[`ingestion_config()`][SiftStreamBuilderPy::ingestion_config] to advance to the full
[`ingestion_config()`][SiftStreamBuilderPy::ingestion_config_form] to advance to the full
builder chain.

Returns a coroutine that resolves to a [`SiftStreamPy`].
Expand Down
8 changes: 4 additions & 4 deletions rust/crates/sift_stream_bindings/src/stream/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ pub struct SiftStreamBuilderPy {
enable_tls: bool,
/// Ingestion config form. Must be set before calling [`build()`][SiftStreamBuilderPy::build].
#[pyo3(get, set)]
ingestion_config: Option<IngestionConfigFormPy>,
ingestion_config_form: Option<IngestionConfigFormPy>,
/// Optional run to associate with the stream. Mutually exclusive with `run_id`;
/// if both are set, `run_id` takes precedence.
#[pyo3(get, set)]
Expand All @@ -64,7 +64,7 @@ impl SiftStreamBuilderPy {
uri: uri.into(),
apikey: apikey.into(),
enable_tls: true,
ingestion_config: None,
ingestion_config_form: None,
run: None,
run_id: None,
asset_tags: None,
Expand All @@ -76,12 +76,12 @@ impl SiftStreamBuilderPy {
///
/// This is the quick path: `ingestion_config` must be set; all other fields are optional.
/// For other modes (checkpointing, disk backups, tunable capacities), use
/// [`ingestion_config()`][SiftStreamBuilderPy::ingestion_config] to advance to the full
/// [`ingestion_config()`][SiftStreamBuilderPy::ingestion_config_form] to advance to the full
/// builder chain.
///
/// Returns a coroutine that resolves to a [`SiftStreamPy`].
pub fn build(&mut self, py: Python) -> PyResult<Py<PyAny>> {
let ingestion_config = self.ingestion_config.clone().ok_or_else(|| {
let ingestion_config = self.ingestion_config_form.clone().ok_or_else(|| {
pyo3::exceptions::PyValueError::new_err(
"ingestion_config must be set before calling build()",
)
Expand Down
Loading