rust(fix): allow partial sift-cli config updates#556
Merged
Conversation
solidiquis
approved these changes
May 11, 2026
solidiquis
requested changes
May 11, 2026
Collaborator
solidiquis
left a comment
solidiquis
left a comment
There was a problem hiding this comment.
move test to separate file
wei-qlu
force-pushed
the
rust/individual-config-update
branch
from
fca02af to
75ae414
Compare
solidiquis
previously approved these changes
May 12, 2026
solidiquis
changed the title
solidiquis
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sift-cli config updatewith a subset of--grpc-uri/--rest-uri/--api-keyindividually printed "Nothing to update." and exited.is_update_emptyjoined the three "missing flag" checks with||instead of&&, firing the early return whenever any flag was absent. Flipped the operator and added unit tests for the empty / partial / full cases.Validation
Unit and manual tests