Skip to content

rust(fix): use job ID from upload response for deterministic lookup #576

Merged
wei-qlu merged 2 commits into
mainfrom
rust/job-id-creation
May 20, 2026
Merged

rust(fix): use job ID from upload response for deterministic lookup #576
wei-qlu merged 2 commits into
mainfrom
rust/job-id-creation

Conversation

@wei-qlu
Copy link
Copy Markdown
Contributor

@wei-qlu wei-qlu commented May 19, 2026

Summary

  • Replaces the "latest job for user" lookup with deterministic retrieval by job_id
  • job_id is now read from the upload response body and threaded through wait_for_job_completion
  • Consolidates the inline upload code in csv.rs and parquet/flat_dataset.rs to use the existing upload_gzipped_file helper
  • Removes user.rs helper (only used by the old user-scoped "latest job" lookup)

Validation

  • Manual: sift-cli import csv --wait ... completes and reports the correct job status
  • Manual: same for import parquet, import hdf5, import tdms
  • Manual: temporarily printed job_id and confirmed the printed id matches the job created by the upload in the Sift jobs UI (not a stale or unrelated job)

@wei-qlu wei-qlu force-pushed the rust/job-id-creation branch from 2311398 to 088fade Compare May 19, 2026 22:32
@wei-qlu wei-qlu marked this pull request as ready for review May 20, 2026 00:59
@wei-qlu wei-qlu merged commit d1e6e70 into main May 20, 2026
20 checks passed
@wei-qlu wei-qlu deleted the rust/job-id-creation branch May 20, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants