Skip to content

python(feat): add HDF5 schema detection#593

Merged
wei-qlu merged 10 commits into
mainfrom
python/add-hdf5-schemas
May 28, 2026
Merged

python(feat): add HDF5 schema detection#593
wei-qlu merged 10 commits into
mainfrom
python/add-hdf5-schemas

Conversation

@wei-qlu
Copy link
Copy Markdown
Contributor

@wei-qlu wei-qlu commented May 27, 2026

Summary

  • Adds Hdf5Schema enum (ONE_D, TWO_D, COMPOUND) and a required hdf5_schema parameter on import_from_path and detect_config.
  • Implements per-schema detection in _internal/util/hdf5.py, datasets that don't fit the chosen schema are not included.

Test plan

  • Imported a test HDF5 file under each schema (ONE_D, TWO_D, COMPOUND); imports completed and channels matched expectations
  • Confirmed import_from_path("file.h5", ...) without hdf5_schema raises a clear ValueError
  • Unit tests cover each schema's happy path, filter behavior, and the shared primitives

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Python docs preview: https://sift-stack.github.io/sift/python/pr-593/

Deployed from c337f8b. The link may take up to a minute to become live as GitHub Pages propagates.

@wei-qlu wei-qlu requested a review from marc-sift May 27, 2026 07:48
@wei-qlu wei-qlu marked this pull request as ready for review May 27, 2026 08:02
Comment thread python/lib/sift_client/resources/data_imports.py Outdated
Comment thread python/lib/sift_client/resources/data_imports.py Outdated
Comment thread python/lib/sift_client/_internal/util/hdf5.py Outdated
Comment thread python/lib/sift_client/_internal/util/hdf5.py Outdated
Comment thread python/lib/sift_client/sift_types/data_import.py Outdated
Comment thread python/lib/sift_client/resources/data_imports.py Outdated
@wei-qlu wei-qlu requested a review from marc-sift May 28, 2026 19:30
@wei-qlu wei-qlu merged commit 2b13f10 into main May 28, 2026
23 checks passed
@wei-qlu wei-qlu deleted the python/add-hdf5-schemas branch May 28, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants