python(fix): bound sync calls at the transport layer#613
Merged
Conversation
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-613/ Deployed from |
alexluck-sift
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sync timeout cap wrapped the whole coroutine, so it aborted long-running waiters (wait_until_complete, wait_and_download) at the cap even when they were polling fine or the caller passed a larger timeout_secs.
This removes the cap and bounds calls at the transport layer instead: gRPC keeps its 60s deadline, and REST gets a default 60s timeout it never had (an inter-byte read timeout, so stalled sockets fail fast but healthy long downloads don't). Waiters now honor their own timeout_secs.
REST requests now default to a 60s timeout, configurable via RestConfig(request_timeout=...) and overridable per call.
Test plan
and gRPC deadline tests).
wait_until_complete() runs to completion instead of being cut off at the old cap.