feat: integration tests poll requests by RPC instead of indexer#513
Merged
ChaoticTempest merged 6 commits intodevelopfrom Sep 9, 2025
Merged
feat: integration tests poll requests by RPC instead of indexer#513ChaoticTempest merged 6 commits intodevelopfrom
ChaoticTempest merged 6 commits intodevelopfrom
Conversation
ChaoticTempest
force-pushed
the
phuong/feat/near-rpc-requests
branch
from
72340f4 to
a72ad79
Compare
volovyks
reviewed
Sep 9, 2025
| #[derive(Debug, Clone, clap::Parser)] | ||
| #[group(id = "indexer_options")] | ||
| pub struct Options { | ||
| /// AWS S3 bucket name for NEAR Lake Indexer |
Contributor
There was a problem hiding this comment.
@auto-mausx multiple parameters become redundant, please, represent that in our docs.
ppca
approved these changes
Sep 9, 2025
Contributor
|
This is easy to miss but actually really awesome to get cleaned up! It really helps with compilation time as well as the time to run tests. The time for running integrations tests in CI went down from 41-42 minutes to just 31-33 minutes. These are the timing for the 3 time consuming steps:
Thanks @ChaoticTempest for getting this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that requests from near contract come in by RPC instead of indexer.
indexer.rsnow just polls the near contract for pending requests.Changes
near_workspaces::sandboxdirectly now.