Conversation
Contributor
Isn't that the expected behaviour? |
Contributor
Author
|
yes, but that also means that we're stuck in syncing state forever if sync fails, which it won't yet because we are not responding with anything yet |
ppca
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a point where in the update for
MeshState, we weren't removeneed_syncwhen transitioning toActive. Also, the connection wasn't transitioning properly as it would overwrite the syncing on the next ping.This fixes those issues, but might put us in the syncing state if sync is going to fail. If it becomes an issue on devnet, will fix later. Just trying to keep this fix small for now. The unit tests for mesh have been updated to accommodate syncing state.