small: make derive_user_address() public so solana-contract-examples can use it#581
Merged
small: make derive_user_address() public so solana-contract-examples can use it#581
Conversation
added 2 commits
October 28, 2025 13:25
ppca
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the derive_user_address() function for external use by solana-contract-examples and enables the serde feature for alloy-consensus to support serialization requirements.
- Made
derive_user_address()function public in the chain-signatures node - Enabled serde feature for alloy-consensus dependency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chain-signatures/node/src/sign_bidirectional.rs | Changed derive_user_address() visibility from private to public |
| Cargo.toml | Added serde feature to alloy-consensus dependency specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChaoticTempest
approved these changes
Oct 29, 2025
| secp256k1 = "0.28.2" | ||
| rlp = "0.5" | ||
| alloy-consensus = "1.0.38" | ||
| alloy-consensus = { version = "1.0.38", features = ["serde"] } |
Contributor
There was a problem hiding this comment.
did we have to add this new feature flag if we're only just making derive_user_address public?
Contributor
Author
There was a problem hiding this comment.
Yes this is needed otherwise solana-contract-examples won't compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also includes adding serde feature to alloy-consensus so solana-contract-examples can use it