feat: add protocol versioning #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
force-pushed
the
phuong/feat/mpc-versioning
branch
from
942a1c0 to
671824a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds protocol versioning to the /status endpoint to enable version compatibility checks between nodes. The implementation sets PROTOCOL_VERSION to 1 (distinguishing from the mainnet default of 0) and wraps the status response in a new StatusResponse struct that includes the version number.
Key changes:
- Introduces a
PROTOCOL_VERSIONconstant set to 1 - Wraps the
/statusendpoint response in aStatusResponsestruct containing both the status and protocol version - Implements protocol version checking in node connections to mark incompatible nodes as offline
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
chain-signatures/node/src/lib.rs |
Defines PROTOCOL_VERSION constant as 1 |
chain-signatures/node/src/web/mod.rs |
Introduces StatusResponse struct and updates the /status endpoint to return it with protocol version |
chain-signatures/node/src/node_client.rs |
Updates client to expect StatusResponse instead of NodeStatus from the /status endpoint |
chain-signatures/node/src/mesh/connection.rs |
Adds protocol version validation logic to mark nodes with mismatched versions as offline |
chain-signatures/node/src/web/mock.rs |
Updates mock server to support protocol version testing, including backward compatibility mode |
chain-signatures/node/src/mesh/mod.rs |
Adds comprehensive test for protocol version mismatch behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jakmeier
approved these changes
Nov 27, 2025
| } | ||
|
|
||
| #[test(tokio::test)] | ||
| async fn test_protocol_version_mismatch_marks_offline() { |
Contributor
|
@ChaoticTempest thanks for looking into this! |
ppca
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Add protocol versioning * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in protocol versioning to /status. Defaults PROTOCOL_VERSION to 1, since 0 is what we have mainnet.