Conversation
jakmeier
previously approved these changes
Mar 12, 2026
Contributor
Author
|
cases::mpc::test_sign_contention_5_nodes issue is back... |
Contributor
Author
|
I've checked our metrics, sync call takes ~15 seconds, and it is O(N), so this time can change. I will look into ways to make it more efficient. |
Contributor
Author
|
Ok, I think that long /sync was caused by an outdated storage version. Now it is ~1s with a large stockpile of Ts and Ps. But I still think we can increase the limits, since /sync process is rare. |
ChaoticTempest
previously approved these changes
Mar 18, 2026
volovyks
commented
Mar 18, 2026
| /// This test generates triples and presignatures on-the-fly (slower but more realistic). | ||
| /// Uses 5_nodes.json fixture for pre-shared keys only. | ||
| #[test(tokio::test(flavor = "multi_thread"))] | ||
| #[ignore] |
Contributor
Author
There was a problem hiding this comment.
Turning this test off temporarily to be able to merge PRs and fix dev
Contributor
There was a problem hiding this comment.
yeah probably a good idea, it really slows us down right now
jakmeier
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync is failing on dev, because the default timeout on the client level is ~1s
I've also increased the waiting time in other places to make sure nodes have enough time to process all the artifacts