feat: try to include all deliberators in signing#765
Merged
jakmeier merged 1 commit intosig-net:developfrom Apr 23, 2026
Merged
feat: try to include all deliberators in signing#765jakmeier merged 1 commit intosig-net:developfrom
jakmeier merged 1 commit intosig-net:developfrom
Conversation
Instead of starting eagerly, give all deliberators some time to response with accept. This avoids that with every signature, N-threshold nodes fall into the bad state where they keep trying to form a new posit round, even when they could have been included in the first round.
ChaoticTempest
approved these changes
Apr 23, 2026
Contributor
ChaoticTempest
left a comment
ChaoticTempest
left a comment
There was a problem hiding this comment.
nice, thanks for adding this in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of starting eagerly, give all deliberators some time to response with accept.
This avoids that with every signature, N-threshold nodes fall into the bad state where they keep trying to form a new posit round, even when they could have been
included in the first round.