Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6 . Added Shard's that are locked for writes.
FAIL
sakarsinghal@Sakars-Mac-mini lorem-lsm % go test -bench=BenchmarkPutConcurrent ./db
goos: darwin
goarch: arm64
pkg: lorem-lsm/db
cpu: Apple M4
BenchmarkPutConcurrent/bloom=true,lock=true,shardCount=1-10 142864 10246 ns/op
BenchmarkPutConcurrent/bloom=false,lock=true,shardCount=1-10 120465 11651 ns/op
BenchmarkPutConcurrent/bloom=true,lock=true,shardCount=2-10 155450 10179 ns/op
BenchmarkPutConcurrent/bloom=false,lock=true,shardCount=2-10 134534 8539 ns/op
PASS
ok lorem-lsm/db 6.116s
sakarsinghal@Sakars-Mac-mini lorem-lsm % go test -bench=BenchmarkGetConcurrent ./db
goos: darwin
goarch: arm64
pkg: lorem-lsm/db
cpu: Apple M4
BenchmarkGetConcurrent/bloom=true,lock=true,shardCount=1-10 690308 1577 ns/op
BenchmarkGetConcurrent/bloom=false,lock=true,shardCount=1-10 667656 1530 ns/op
BenchmarkGetConcurrent/bloom=true,lock=true,shardCount=5-10 21271268 812.5 ns/op
BenchmarkGetConcurrent/bloom=false,lock=true,shardCount=5-10 23123714 675.9 ns/op
PASS
ok lorem-lsm/db 39.041s